Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BSTVM #11304

Merged
merged 14 commits into from
May 20, 2024
Merged

Fix BSTVM #11304

merged 14 commits into from
May 20, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented May 19, 2024

Seperate PR to focus on the VM and not to "pollute" the student PR. (And I had write issues to the branch there)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions[bot]
github-actions bot reviewed May 19, 2024
View reviewed changes
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/util/TestEntry.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/bst/BstVMVisitor.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/bst/BstVMVisitor.java Outdated Show resolved Hide resolved
@koppor koppor marked this pull request as ready for review May 20, 2024 07:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit c4c0a23 May 20, 2024
21 checks passed
@Siedlerchr Siedlerchr deleted the fix-bst-vm branch May 20, 2024 09:11
Siedlerchr added a commit to sahilsekr42/jabref that referenced this pull request May 20, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-11102
b1ece3b 
* upstream/main:
  Fix BSTVM (JabRef#11304)

# Conflicts:
#	src/main/java/org/jabref/logic/bst/BstVM.java
#	src/main/java/org/jabref/logic/bst/BstVMVisitor.java
#	src/test/java/org/jabref/logic/bst/BstVMTest.java
@calixtus
Copy link
Member

Thanks

This was referenced May 21, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @calixtus @Siedlerchr